qrakhen/qamp
qrakhen
/
qamp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use switch rather than dict lookup

This commit is contained in:
Qrakhen 2025-11-23 07:14:26 +01:00
parent f9f2f5b81a
commit fad93a7973
1 changed files with 183 additions and 163 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
Qrakhen.Qamp.Core/Execution/ValueOperation.cs
View File

@ -1,5 +1,4 @@
using Qrakhen.Qamp.Core.Collections;
using Qrakhen.Qamp.Core.Compilation;
using Qrakhen.Qamp.Core.Logging;
using Qrakhen.Qamp.Core.Values;
@ -20,28 +19,49 @@ public static class ValueOperation
#if LOG
_logger.Method($"{operation.Left} {operation.OpCode} {operation.Right}");
#endif
return _operations[operation.OpCode].Invoke(operation);
// p sure switch is faster here (as opposed to dict lookup)
return operation.OpCode switch {
OpCode.Equal => Equal(operation),
OpCode.Greater => Greater(operation),
OpCode.Less => Less(operation),
OpCode.Not => Not(operation),
OpCode.Add => Add(operation),
OpCode.Subtract => Subtract(operation),
OpCode.Divide => Divide(operation),
OpCode.Modulo => Modulo(operation),
OpCode.Multiply => Multiply(operation),
OpCode.Negate => Negate(operation),
OpCode.BitwiseOr => BitwiseOr(operation),
OpCode.BitwiseAnd => BitwiseAnd(operation),
OpCode.BitwiseLeft => BitwiseLeft(operation),
OpCode.BitwiseRight => BitwiseRight(operation),
OpCode.BitwiseNot => BitwiseInvert(operation),
OpCode.BitwiseXor => BitwiseXor(operation),
_ => throw new NotImplementedException($"Unknown operator {operation.OpCode}.")
};
}
static ValueOperation()
{
_operations = new Register<OpCode, OperationHandler>();
_operations.Add(OpCode.Equal, Equal);
_operations.Add(OpCode.Greater, Greater);
_operations.Add(OpCode.Less, Less);
_operations.Add(OpCode.Not, Not);
_operations.Add(OpCode.Add, Add);
_operations.Add(OpCode.Subtract, Subtract);
_operations.Add(OpCode.Divide, Divide);
_operations.Add(OpCode.Modulo, Modulo);
_operations.Add(OpCode.Multiply, Multiply);
_operations.Add(OpCode.Negate, Negate);
_operations.Add(OpCode.BitwiseOr, BitwiseOr);
_operations.Add(OpCode.BitwiseAnd, BitwiseAnd);
_operations.Add(OpCode.BitwiseLeft, BitwiseLeft);
_operations.Add(OpCode.BitwiseRight, BitwiseRight);
_operations.Add(OpCode.BitwiseNot, BitwiseInvert);
_operations.Add(OpCode.BitwiseXor, BitwiseXor);
_operations = new Register<OpCode, OperationHandler> {
{ OpCode.Equal, Equal },
{ OpCode.Greater, Greater },
{ OpCode.Less, Less },
{ OpCode.Not, Not },
{ OpCode.Add, Add },
{ OpCode.Subtract, Subtract },
{ OpCode.Divide, Divide },
{ OpCode.Modulo, Modulo },
{ OpCode.Multiply, Multiply },
{ OpCode.Negate, Negate },
{ OpCode.BitwiseOr, BitwiseOr },
{ OpCode.BitwiseAnd, BitwiseAnd },
{ OpCode.BitwiseLeft, BitwiseLeft },
{ OpCode.BitwiseRight, BitwiseRight },
{ OpCode.BitwiseNot, BitwiseInvert },
{ OpCode.BitwiseXor, BitwiseXor }
};
}
public static Value Equal(Operation operation)